Agent Memory System

Agent 记忆系统设计助手。构建长期记忆、短期记忆、情景记忆架构。触发词：记忆、memory、上下文管理、上下文窗口。

This skill provides a coherent design and sample code for an agent memory system, but there are several red flags you should consider before using it: - Missing credential declaration: The code calls the OpenAI embeddings endpoint using process.env.OPENAI_API_KEY, yet the skill metadata does not declare any required environment variables. If you supply an API key, the skill's instructions will send content (potentially sensitive) to OpenAI. - Data persistence and exfiltration risk: The design persists arbitrary 'content' to a SQLite DB and a local Chroma vector store, and will send high-importance content to the external embeddings API. Review what you store and avoid putting secrets (passwords, tokens, PII) into memories. - Insecure SQL: The sample code builds SQL with string interpolation (content LIKE '%${k}%'), which is vulnerable to SQL injection. If you implement this, use parameterized queries or proper sanitization. - Missing dependency/runtime notes: The SKILL.md assumes a Node-like environment and libraries (SQLite client, Chroma client, fetch, crypto). The skill metadata doesn't list these — confirm the runtime and add explicit dependency/installation steps before implementation. Recommendations: only use or implement this guidance if you (or a developer you trust) will: 1) Explicitly declare and protect the OPENAI_API_KEY and never store secrets in the memory store; 2) Replace string-interpolated SQL with parameterized queries; 3) Add clear dependency and install instructions; 4) Audit what data will be persisted and sent to external services; and 5) Verify the linked repository (skill.json references a GitHub repo) to inspect full source and history. If you cannot verify these items, treat the skill as potentially unsafe.

Type: OpenClaw Skill Name: openclaw-agent-memory-system Version: 1.0.0 The skill bundle provides a template for an AI memory system that contains a critical SQL injection vulnerability in the `retrieve` method within `SKILL.md`. User-provided search queries are split into keywords and directly interpolated into a SQLite query string without sanitization. While the code accesses `process.env.OPENAI_API_KEY` to fetch embeddings from OpenAI, this behavior aligns with the stated purpose of the memory system and does not appear to be intentional data exfiltration.